This repository was archived by the owner on Sep 17, 2025. It is now read-only.
Add clean target to make file#66
Open
marckhouzam wants to merge 2 commits into
Open
Conversation
It is possible for a user to run make from outside of the acceptance-testing directory. For example $ cd /tmp $ make -f $GOPATH/src/helm.sh/acceptance-testing/Makefile To support this, the Makefile must use the ROOT_DIR of where the Makefile resides, so as to find all other files. Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
The installation of some tools has hard-code paths in them. For example: $ head -1 .acceptance/.venv/bin/robot #!/Users/marckhouzam/git/acceptance-testing/.acceptance/.venv/bin/python3.7 If I want to move the acceptance-testing repo to a new directory on my computer, the installed tools will no longer work due to these hard-coded paths. The simplest solution is to cleanup and re-install them. This commit as a 'make clean' target to easily remove the entire .acceptance directory. Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The installation of some tools has hard-code paths in them. For example:
If I want to move the acceptance-testing repo to a new directory on my computer, the installed tools will no longer work due to these hard-coded paths. The simplest solution is to cleanup and re-install them.
This commit as a 'make clean' target to easily remove the entire .acceptance directory.